-
-
Notifications
You must be signed in to change notification settings - Fork 21k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse pointer reappears at same spot #48980
Conversation
Technical details: If we set Difference between behaviour of spin sliders and other numeric fields: Imo, reappearing at original position is good as a default. Customisation for specific fields can be done thereafter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your first time contribution! Some notes below
I will make the necessary changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! I appreciate the time & effort you put into understanding the code, as shown by your comments above, despite this being a relatively small change. Hopefully the first of many contributions to come!
Thanks! And congrats for your first merged Godot contribution 🎉 |
This fixes #48971
Before changes:
After grabbing and dragging a numeric field, mouse pointer is teleported to top-left.
After changes:
After grabbing and dragging a numeric field, mouse pointer reappears at the same point from where it vanished.
Edit: After incorporating the changes suggested by @EricEzaM, the mouse pointer should now reappear at the spot from where the user grabbed and started dragging.
Note: This PR does not affect the grab and drag behaviour of Spin Sliders. The problem does not exist with Spin Sliders.